[LINTER] Add a linter to replace `unsigned char` with `uint8_t`
ClosedPublic
Actions

Authored by Fabien on Jul 8 2019, 12:08.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING30788b70dd0e: [LINTER] Add a linter to replace `unsigned char` with `uint8_t`
rABC30788b70dd0e: [LINTER] Add a linter to replace `unsigned char` with `uint8_t`

Summary

This is a recurrent issue in reviews, this diffs provides an autofix
linter for this.
It is named afted stdint so that other conversion can be lated added if
needed.

Test Plan

arc lint --everything # No warning

Edit src/init.cpp to add the line:

unsigned char foo;

anywhere in the file, then run:

arc lint -- src/init.cpp

The linter should catch the line and suggest a fix.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

linter_uint8

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6729
Build 11505: Bitcoin ABC Buildbot (legacy)
Build 11504: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 8 2019, 12:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2019, 12:08

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6729: Diff 10078.Jul 8 2019, 12:15

deadalnix accepted this revision.Jul 8 2019, 12:22

This revision is now accepted and ready to land.Jul 8 2019, 12:22

Fabien retitled this revision from Add a linter to replace `unsigned char` with `uint8_t` to [LINTER] Add a linter to replace `unsigned char` with `uint8_t`.Jul 8 2019, 12:30

Closed by commit rABC30788b70dd0e: [LINTER] Add a linter to replace `unsigned char` with `uint8_t` (authored by Fabien). · Explain WhyJul 8 2019, 15:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC30788b70dd0e: [LINTER] Add a linter to replace `unsigned char` with `uint8_t`.

Fabien added a commit: rSTAGING30788b70dd0e: [LINTER] Add a linter to replace `unsigned char` with `uint8_t`.Sep 19 2019, 01:04