Page MenuHomePhabricator

[LINTER] Add a linter to replace `unsigned char` with `uint8_t`
ClosedPublic

Authored by Fabien on Jul 8 2019, 12:08.

Details

Summary

This is a recurrent issue in reviews, this diffs provides an autofix
linter for this.
It is named afted stdint so that other conversion can be lated added if
needed.

Test Plan
arc lint --everything # No warning

Edit src/init.cpp to add the line:

unsigned char foo;

anywhere in the file, then run:

arc lint -- src/init.cpp

The linter should catch the line and suggest a fix.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 8 2019, 12:22
Fabien retitled this revision from Add a linter to replace `unsigned char` with `uint8_t` to [LINTER] Add a linter to replace `unsigned char` with `uint8_t`.Jul 8 2019, 12:30