Page MenuHomePhabricator
Differential D3594

Partial backport of Core PR11167 to have similar feature in base58_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on Jul 8 2019, 14:00.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGef3a4e71ac11: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp
rABCef3a4e71ac11: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp
Summary

As per title. This was raised in D3578.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11167test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6732
Build 11511: Bitcoin ABC Buildbot (legacy)
Build 11510: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 8 2019, 14:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2019, 14:00
teamcity added a comment.Jul 8 2019, 14:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6732: Diff 10087.Jul 8 2019, 14:07
teamcity added a comment.Jul 8 2019, 14:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix mentioned this in D3578: Split off key_io_tests from base58_tests.Jul 8 2019, 14:08
markblundeberg accepted this revision.Jul 8 2019, 14:14
markblundeberg added a subscriber: markblundeberg.

Ah man, one of those backports ... I wonder if we missed something else relevant, I guess we'll just have to find out later when doing dependencies.

This revision is now accepted and ready to land.Jul 8 2019, 14:14
Closed by commit rABCef3a4e71ac11: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJul 8 2019, 15:51
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCef3a4e71ac11: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp.
deadalnix added a commit: rSTAGINGef3a4e71ac11: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp.Sep 19 2019, 01:03

Revision Contents
Changeset List

PathSize
src/
test/
21 lines

Diff 10087

View Options

src/test/base58_tests.cpp

Loading...