Fix checkqueue_tests use-after-scope
ClosedPublic
Actions

Authored by Fabien on Jul 8 2019, 20:45.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGc9911ddd7dc2: Fix checkqueue_tests use-after-scope
rABCc9911ddd7dc2: Fix checkqueue_tests use-after-scope

Summary

This reverts the change to checkqueue_tests from D3146 to reapply the
fix from PR12477 (see D3566).

Test Plan

With ASAN enabled:

src/test/test_bitcoin -t checkqueue_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_checkqueue_tests_asan

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6745
Build 11537: Bitcoin ABC Buildbot (legacy)
Build 11536: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 8 2019, 20:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2019, 20:45

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6745: Diff 10114.Jul 8 2019, 20:51

jasonbcox accepted this revision.Jul 8 2019, 20:57

This revision is now accepted and ready to land.Jul 8 2019, 20:57

Closed by commit rABCc9911ddd7dc2: Fix checkqueue_tests use-after-scope (authored by Fabien). · Explain WhyJul 9 2019, 05:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc9911ddd7dc2: Fix checkqueue_tests use-after-scope.

Fabien added a commit: rSTAGINGc9911ddd7dc2: Fix checkqueue_tests use-after-scope.Sep 19 2019, 01:05

Revision Contents
Changeset List

Path

Size

src/

test/

checkqueue_tests.cpp

8 lines

Diff 10114

View Options

src/test/checkqueue_tests.cpp

Fix checkqueue_tests use-after-scopeClosedPublicActions