Merge #10627: fixed listunspent rpc convert parameter
ClosedPublic
Actions

Authored by nakihito on Jul 8 2019, 22:05.

Details

Reviewers

deadalnix
Fabien
jasonbcox
markblundeberg

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING2d5a8a743b02: Merge #10627: fixed listunspent rpc convert parameter
rABC2d5a8a743b02: Merge #10627: fixed listunspent rpc convert parameter

Summary

e503b2b fixed listunspent rpc convert parameter (tnaka)

Tree-SHA512: 6da1cee8fd8459187825fad47678b36bbf6b4582f03f557c8a48c2c4273d9e12405e8bb6ade02a06e6555419eefb1dc298d4d4781ebb3b6b72743ca6108cb18e

Backport of Core PR10627
https://github.com/bitcoin/bitcoin/pull/10627

Test Plan

make check
test_runner.py
./bitcoind
./bitcoin-cli listunspent 1 9999999 "[]" true

The last line should return as expected with list_unsafe=true. Before, it would error out with:

error code: -3
error message:
Expected type bool, got string

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 8 2019, 22:05

Owners added a reviewer: Restricted Owners Package.Jul 8 2019, 22:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2019, 22:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6747: Diff 10116.Jul 8 2019, 22:11

deadalnix accepted this revision.Jul 9 2019, 01:04

This revision is now accepted and ready to land.Jul 9 2019, 01:04

Closed by commit rABC2d5a8a743b02: Merge #10627: fixed listunspent rpc convert parameter (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJul 9 2019, 19:10

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC2d5a8a743b02: Merge #10627: fixed listunspent rpc convert parameter.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING2d5a8a743b02: Merge #10627: fixed listunspent rpc convert parameter.Sep 19 2019, 01:07

Revision Contents
Changeset List

Path

Size

src/

rpc/

client.cpp

1 line

Diff 10156

View Options

Merge #10627: fixed listunspent rpc convert parameterClosedPublicActions