Page MenuHomePhabricator

[script_tests] add tests for pubkey encoding with strictenc + nullfail
ClosedPublic

Authored by markblundeberg on Tue, Jul 9, 16:19.

Details

Summary

During discussion of D3473 an optimization for the NULLFAIL check was
proposed. If implemented naively with bail-early mechanics, it could
lead to an inadvertent consensus change due to interaction with
STRICTENC. From what I can tell this was not covered by test vectors.

Depends on D3612.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Tue, Jul 9, 16:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 9, 16:19
deadalnix accepted this revision.Tue, Jul 9, 20:30

Accepting, but this probably needs to be shuffled around based on change in the parent's diff.

This revision is now accepted and ready to land.Tue, Jul 9, 20:30

Accepting, but this probably needs to be shuffled around based on change in the parent's diff.

Should the valid/invalid separation be kept?