Page MenuHomePhabricator
Differential D3613

[script_tests] add tests for pubkey encoding with strictenc + nullfail
ClosedPublic
Actions

Authored by markblundeberg on Jul 9 2019, 16:19.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGINGe1feff241410: [script_tests] add tests for pubkey encoding with strictenc + nullfail
rABCe1feff241410: [script_tests] add tests for pubkey encoding with strictenc + nullfail
Summary

During discussion of D3473 an optimization for the NULLFAIL check was
proposed. If implemented naively with bail-early mechanics, it could
lead to an inadvertent consensus change due to interaction with
STRICTENC. From what I can tell this was not covered by test vectors.

Depends on D3612.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jul 9 2019, 16:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 16:19
teamcity added a comment.Jul 9 2019, 16:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg mentioned this in D3473: [refactor multisig] consolidate legacy mode logic.Jul 9 2019, 16:25
teamcity added a comment.Jul 9 2019, 16:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6762: Diff 10135.Jul 9 2019, 16:29
deadalnix accepted this revision.Jul 9 2019, 20:30

Accepting, but this probably needs to be shuffled around based on change in the parent's diff.

This revision is now accepted and ready to land.Jul 9 2019, 20:30
markblundeberg added a comment.Jul 9 2019, 21:34
In D3613#85311, @deadalnix wrote:

Accepting, but this probably needs to be shuffled around based on change in the parent's diff.

Should the valid/invalid separation be kept?

Closed by commit rABCe1feff241410: [script_tests] add tests for pubkey encoding with strictenc + nullfail (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 10 2019, 02:03
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCe1feff241410: [script_tests] add tests for pubkey encoding with strictenc + nullfail.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGe1feff241410: [script_tests] add tests for pubkey encoding with strictenc + nullfail.Sep 19 2019, 01:09

Revision Contents
Changeset List

PathSize
src/
test/
data/
35 lines

Diff 10180

View Options

src/test/data/script_tests.json

Loading...