Page MenuHomePhabricator

Merge #14571: [tests] Test that nodes respond to getdata with notfound
ClosedPublic

Authored by markblundeberg on Tue, Jul 9, 17:54.

Details

Summary

PR14571 backport https://github.com/bitcoin/bitcoin/pull/14571/files
fa78a2fc67 [tests] Test that nodes respond to getdata with notfound (MarcoFalke)

Pull request description:

If a node has not announced a tx at all, then it should respond to
getdata messages for that tx with notfound, to avoid leaking tx
origination privacy.

In the future this could be adjusted such that a node responds with
notfound when a tx has not been announced to us, but that seems
to be a more involved change. See e.g.
https://github.com/jnewbery/bitcoin/commits/pr14220.1

Backport note: this was backported a bit early, but it runs nicely with
two extra lines included (as marked in comment).

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Tue, Jul 9, 17:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 9, 17:54
markblundeberg added a comment.EditedTue, Jul 9, 17:58

The backports that would remove the need for those two lines:

They can't be backported yet due to another internal change that breaks comptool (so comptool should be removed first, but that will take some time): https://github.com/bitcoin/bitcoin/pull/13512/

deadalnix accepted this revision.Tue, Jul 9, 20:22
This revision is now accepted and ready to land.Tue, Jul 9, 20:22