Merge #14571: [tests] Test that nodes respond to getdata with notfound
ClosedPublic
Actions

Authored by markblundeberg on Jul 9 2019, 17:54.

Details

Reviewers

jasonbcox
Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING6699751c2d32: Merge #14571: [tests] Test that nodes respond to getdata with notfound
rABC6699751c2d32: Merge #14571: [tests] Test that nodes respond to getdata with notfound

Summary

PR14571 backport https://github.com/bitcoin/bitcoin/pull/14571/files
fa78a2fc67 [tests] Test that nodes respond to getdata with notfound (MarcoFalke)

Pull request description:

If a node has not announced a tx at all, then it should respond to
getdata messages for that tx with notfound, to avoid leaking tx
origination privacy.

In the future this could be adjusted such that a node responds with
notfound when a tx has not been announced to us, but that seems
to be a more involved change. See e.g.
https://github.com/jnewbery/bitcoin/commits/pr14220.1

Backport note: this was backported a bit early, but it runs nicely with
two extra lines included (as marked in comment).

Test Plan

test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jul 9 2019, 17:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 17:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

The backports that would remove the need for those two lines:

"qa: Remove need to handle the network thread in tests" https://github.com/bitcoin/bitcoin/pull/13517
"qa: wait_for_verack by default" https://github.com/bitcoin/bitcoin/pull/13916

They can't be backported yet due to another internal change that breaks comptool (so comptool should be removed first, but that will take some time): https://github.com/bitcoin/bitcoin/pull/13512/

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6764: Diff 10138.Jul 9 2019, 18:00

deadalnix accepted this revision.Jul 9 2019, 20:22

This revision is now accepted and ready to land.Jul 9 2019, 20:22

Closed by commit rABC6699751c2d32: Merge #14571: [tests] Test that nodes respond to getdata with notfound (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 9 2019, 22:04

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC6699751c2d32: Merge #14571: [tests] Test that nodes respond to getdata with notfound.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING6699751c2d32: Merge #14571: [tests] Test that nodes respond to getdata with notfound.Sep 19 2019, 01:08