Page MenuHomePhabricator

Merge #14571: [tests] Test that nodes respond to getdata with notfound

Authored by markblundeberg on Jul 9 2019, 17:54.



PR14571 backport
fa78a2fc67 [tests] Test that nodes respond to getdata with notfound (MarcoFalke)

Pull request description:

If a node has not announced a tx at all, then it should respond to
getdata messages for that tx with notfound, to avoid leaking tx
origination privacy.

In the future this could be adjusted such that a node responds with
notfound when a tx has not been announced to us, but that seems
to be a more involved change. See e.g.

Backport note: this was backported a bit early, but it runs nicely with
two extra lines included (as marked in comment).

Test Plan

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jul 9 2019, 17:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 17:54
markblundeberg added a comment.EditedJul 9 2019, 17:58

The backports that would remove the need for those two lines:

They can't be backported yet due to another internal change that breaks comptool (so comptool should be removed first, but that will take some time):

deadalnix accepted this revision.Jul 9 2019, 20:22
This revision is now accepted and ready to land.Jul 9 2019, 20:22