Page MenuHomePhabricator
Differential D3620

Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache)
ClosedPublic
Actions

Authored by nakihito on Jul 9 2019, 21:07.

Details

Reviewers
deadalnix
Fabien
jasonbcox
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGbd9e25638438: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache)
rABCbd9e25638438: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache)
Summary

21180ff Simplify return values of GetCoin/HaveCoin(InCache) (Pieter Wuille)

Tree-SHA512: eae0aa64fa1308191100cdc7cdc790c825f33b066c200a18b5895d7d5806cee1cc4caba1766ef3379a7cf93dde4bbae2bc9be92947935f5741f5c126d3ee991b

Backport of Core PR10581
https://github.com/bitcoin/bitcoin/pull/10581

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10581
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6776
Build 11599: Bitcoin ABC Buildbot (legacy)
Build 11598: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 9 2019, 21:07
Owners added a reviewer: Restricted Owners Package.Jul 9 2019, 21:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 21:07
teamcity added a comment.Jul 9 2019, 21:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito added a comment.Jul 9 2019, 21:09

GetCoin() in txmempool.h was changed here: https://reviews.bitcoinabc.org/D763#change-X7xlaclCBwBo

teamcity added a comment.Jul 9 2019, 21:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6776: Diff 10160.Jul 9 2019, 21:16
nakihito added a child revision: D3621: Merge #10684: Remove no longer used mempool.exists(outpoint).Jul 9 2019, 22:40
deadalnix requested changes to this revision.Jul 9 2019, 23:25
deadalnix added inline comments.
src/coins.h
141

Fix style.

This revision now requires changes to proceed.Jul 9 2019, 23:25
nakihito updated this revision to Diff 10165.Jul 9 2019, 23:32

Fixed comment formatting.

teamcity added a comment.Jul 9 2019, 23:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 9 2019, 23:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6779: Diff 10165.Jul 9 2019, 23:42
deadalnix accepted this revision.Jul 9 2019, 23:42
This revision is now accepted and ready to land.Jul 9 2019, 23:42
Closed by commit rABCbd9e25638438: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache) (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJul 10 2019, 00:01
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCbd9e25638438: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGbd9e25638438: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).Sep 19 2019, 01:08

Revision Contents
Changeset List

PathSize
src/
8 lines
9 lines
test/
24 lines
1 line
7 lines

Diff 10160

View Options

src/coins.h

Loading...
View Options

src/coins.cpp

Loading...
View Options

src/test/coins_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...