Factor out outpoint generation in transaction_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on Jul 10 2019, 23:26.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6a813cdb8da7: Factor out outpoint generation in transaction_tests.cpp
rABC6a813cdb8da7: Factor out outpoint generation in transaction_tests.cpp

Summary

As per title. Also properly use TxId.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txtesttxid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6812
Build 11671: Bitcoin ABC Buildbot (legacy)
Build 11670: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 10 2019, 23:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 23:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6812: Diff 10218.Jul 10 2019, 23:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D3647: Enforce the use of TxId when constructing COutPoint.Jul 10 2019, 23:49

jasonbcox accepted this revision.Jul 11 2019, 19:49

This revision is now accepted and ready to land.Jul 11 2019, 19:49

Closed by commit rABC6a813cdb8da7: Factor out outpoint generation in transaction_tests.cpp (authored by deadalnix). · Explain WhyJul 11 2019, 20:31

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC6a813cdb8da7: Factor out outpoint generation in transaction_tests.cpp.

deadalnix added a commit: rSTAGING6a813cdb8da7: Factor out outpoint generation in transaction_tests.cpp.Sep 19 2019, 01:13

Revision Contents
Changeset List

Path

Size

src/

test/

transaction_tests.cpp

16 lines

Diff 10218

View Options

src/test/transaction_tests.cpp

Factor out outpoint generation in transaction_tests.cppClosedPublicActions