Page MenuHomePhabricator

[CMAKE] Use plural form when multiple arguments are expected
ClosedPublic

Authored by Fabien on Aug 5 2019, 14:27.

Details

Summary

Some add_xxx_flag() functions can actually take multiple flags are
argument. Rename them to add_xxx_flags() (note the 's') makes it
clearer and more consistent with other function names.

There is no behavior change.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_flags_vs_flag
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7042
Build 12131: Bitcoin ABC Buildbot (legacy)
Build 12130: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 5 2019, 20:52