Page MenuHomePhabricator
Differential D3808

Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size
ClosedPublic
Actions

Authored by markblundeberg on Aug 6 2019, 18:49.

Details

Reviewers
jasonbcox
Fabien
deadalnix
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGINGe1f6c608646e: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size
rABCe1f6c608646e: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size
Summary

PR12460 backport https://github.com/bitcoin/bitcoin/pull/12460/files
f8c249ab91 Assert CPubKey::ValidLength to the pubkey's header-relevent size (Ben Woosley)

Pull request description:

A pubkey's length is specific to its type which is indicated by its header value. GetLen returns the header-indicated length, so this change ensures that a key matches its header-indicated length.

And replace some magic values with their constant equivalents.

Backporter note: the changes to IsCompressedOrUncompressedPubKey and
IsCompressedPubKey needed to be massaged somewhat (due to D1569)

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
validsize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7055
Build 12157: Bitcoin ABC Buildbot (legacy)
Build 12156: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Aug 6 2019, 18:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2019, 18:49
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 6 2019, 18:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 6 2019, 18:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7055: Diff 10637.Aug 6 2019, 18:59
markblundeberg added a child revision: D3810: Merge #13194: Remove template matching and pseudo opcodes.Aug 6 2019, 19:02
jasonbcox accepted this revision.Aug 6 2019, 19:08
This revision is now accepted and ready to land.Aug 6 2019, 19:08
nakihito accepted this revision.Aug 6 2019, 22:21
Closed by commit rABCe1f6c608646e: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyAug 6 2019, 22:29
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCe1f6c608646e: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGe1f6c608646e: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size.Sep 19 2019, 01:39

Revision Contents
Changeset List

PathSize
src/
2 lines
4 lines
script/
6 lines
4 lines

Diff 10637

View Options

src/keystore.cpp

Loading...
View Options

src/pubkey.h

Loading...
View Options

src/script/sigencoding.cpp

Loading...
View Options

src/script/standard.cpp

Loading...