Page MenuHomePhabricator

Merge #11015: [Qt] Add delay before filtering transactions
ClosedPublic

Authored by nakihito on Thu, Aug 8, 23:24.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCf74e946c56b3: Merge #11015: [Qt] Add delay before filtering transactions
Summary

7b137aced [Qt] Add delay before filtering transactions Fixes 3141 (Lucas Betschart)

Pull request description:

As discussed in https://github.com/bitcoin/bitcoin/issues/3141.

This adds a QTimer pause of 200ms before start to filter so it should be possible to filter big data sets easier.

Tree-SHA512: ee599367794eac2c5b8bc7ecac47f44295e40c0ff543ff2f2c4860590f917b59b1cfb273fa564e6eb4c44016c0ef412d49f1a8f1b36b07e034022f51bb76653c

Backport of Core PR11015
https://github.com/bitcoin/bitcoin/pull/11015/

Test Plan
make check
./bitcoin-qt -> transactions -> enter a filter

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Thu, Aug 8, 23:24
Owners added a reviewer: Restricted Owners Package.Thu, Aug 8, 23:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Aug 8, 23:24
nakihito planned changes to this revision.Thu, Aug 8, 23:55
nakihito requested review of this revision.Mon, Aug 12, 22:55
jasonbcox accepted this revision.Tue, Aug 13, 01:19
jasonbcox added inline comments.
src/qt/transactionview.cpp
121 ↗(On Diff #10686)

all-caps for constants

This revision is now accepted and ready to land.Tue, Aug 13, 01:19
Fabien accepted this revision.Tue, Aug 13, 06:57