Merge #11015: [Qt] Add delay before filtering transactions
ClosedPublic
Actions

Authored by nakihito on Aug 8 2019, 23:24.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGf74e946c56b3: Merge #11015: [Qt] Add delay before filtering transactions
rABCf74e946c56b3: Merge #11015: [Qt] Add delay before filtering transactions

Summary

7b137aced [Qt] Add delay before filtering transactions Fixes 3141 (Lucas Betschart)

Pull request description:

As discussed in https://github.com/bitcoin/bitcoin/issues/3141.

This adds a QTimer pause of 200ms before start to filter so it should be possible to filter big data sets easier.

Tree-SHA512: ee599367794eac2c5b8bc7ecac47f44295e40c0ff543ff2f2c4860590f917b59b1cfb273fa564e6eb4c44016c0ef412d49f1a8f1b36b07e034022f51bb76653c

Backport of Core PR11015
https://github.com/bitcoin/bitcoin/pull/11015/

Test Plan

make check
./bitcoin-qt -> transactions -> enter a filter

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 8 2019, 23:24

Owners added a reviewer: Restricted Owners Package.Aug 8 2019, 23:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 8 2019, 23:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7090: Diff 10686.Aug 8 2019, 23:31

nakihito planned changes to this revision.Aug 8 2019, 23:55

nakihito added a child revision: D3833: Merge #11395: Qt: Enable searching by transaction id.Aug 8 2019, 23:57

nakihito requested review of this revision.Aug 12 2019, 22:55

jasonbcox accepted this revision.Aug 13 2019, 01:19

jasonbcox added inline comments.

src/qt/transactionview.cpp
121 ↗	(On Diff #10686)	all-caps for constants

This revision is now accepted and ready to land.Aug 13 2019, 01:19

Fabien accepted this revision.Aug 13 2019, 06:57

Closed by commit rABCf74e946c56b3: Merge #11015: [Qt] Add delay before filtering transactions (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by nakihito). · Explain WhyAug 13 2019, 17:57

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCf74e946c56b3: Merge #11015: [Qt] Add delay before filtering transactions.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGf74e946c56b3: Merge #11015: [Qt] Add delay before filtering transactions.Sep 19 2019, 01:48

Revision Contents
Changeset List

Path

Size

src/

qt/

transactionview.h

4 lines

transactionview.cpp

34 lines

Diff 10763

View Options

src/qt/transactionview.h