Page MenuHomePhabricator

Merge #12621: Avoid querying unnecessary model data when filtering transactions
ClosedPublic

Authored by nakihito on Tue, Aug 6, 20:25.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC7ee85b34ec74: Merge #12621: Avoid querying unnecessary model data when filtering transactions
Summary

1ee72a819f qt: Avoid querying unnecessary model data when filtering transactions (João Barbosa)

Pull request description:

This change moves down model data querying to where it's needed. The worst case remains the same (all data is queried and the row passes) but for the average case it improves the filter performance.

Tree-SHA512: 3bcaced029cb39dfbc5377246ce76634f9050ee3a3053db4d358fcbf4d8107c649e75841f21d69f1aebcaf1bbffe3eac784e6b03b366fdbbfec1e0da8f78d8ef

Backport of Core PR12621
https://github.com/bitcoin/bitcoin/pull/12621/

Depends on D3833

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Aug 6, 20:25
Owners added a reviewer: Restricted Owners Package.Tue, Aug 6, 20:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Aug 6, 20:25
Fabien requested changes to this revision.Wed, Aug 7, 08:33
Fabien added inline comments.
src/qt/transactionfilterproxy.cpp
55 ↗(On Diff #10644)

There is a dependency missing here:
https://github.com/bitcoin/bitcoin/pull/11395/files

This revision now requires changes to proceed.Wed, Aug 7, 08:33
nakihito planned changes to this revision.Wed, Aug 7, 17:43

Missed a dependency. Will update once completed.

nakihito updated this revision to Diff 10746.Mon, Aug 12, 23:02

Rebased off dependency.

nakihito planned changes to this revision.Mon, Aug 12, 23:02
nakihito updated this revision to Diff 10766.Tue, Aug 13, 18:19

Rebased.

Fabien requested changes to this revision.Wed, Aug 14, 08:04
Fabien added inline comments.
src/qt/transactionfilterproxy.cpp
31 ↗(On Diff #10766)

Remove

65 ↗(On Diff #10766)

Why ?

69 ↗(On Diff #10766)

Dito

This revision now requires changes to proceed.Wed, Aug 14, 08:04
nakihito updated this revision to Diff 10790.Wed, Aug 14, 18:07

Fixed amount initialization and removed newlines.

Fabien accepted this revision.Fri, Aug 16, 07:57
This revision is now accepted and ready to land.Fri, Aug 16, 07:57