Page MenuHomePhabricator

Merge #12621: Avoid querying unnecessary model data when filtering transactions
ClosedPublic

Authored by nakihito on Aug 6 2019, 20:25.

Details

Summary

1ee72a819f qt: Avoid querying unnecessary model data when filtering transactions (João Barbosa)

Pull request description:

This change moves down model data querying to where it's needed. The worst case remains the same (all data is queried and the row passes) but for the average case it improves the filter performance.

Tree-SHA512: 3bcaced029cb39dfbc5377246ce76634f9050ee3a3053db4d358fcbf4d8107c649e75841f21d69f1aebcaf1bbffe3eac784e6b03b366fdbbfec1e0da8f78d8ef

Backport of Core PR12621
https://github.com/bitcoin/bitcoin/pull/12621/

Depends on D3833

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12621
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7061
Build 12169: Bitcoin ABC Buildbot (legacy)
Build 12168: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 6 2019, 20:25
Fabien requested changes to this revision.Aug 7 2019, 08:33
Fabien added inline comments.
src/qt/transactionfilterproxy.cpp
55

There is a dependency missing here:
https://github.com/bitcoin/bitcoin/pull/11395/files

This revision now requires changes to proceed.Aug 7 2019, 08:33

Missed a dependency. Will update once completed.

Fabien requested changes to this revision.Aug 14 2019, 08:04
Fabien added inline comments.
src/qt/transactionfilterproxy.cpp
31 ↗(On Diff #10766)

Remove

65 ↗(On Diff #10766)

Why ?

69 ↗(On Diff #10766)

Dito

This revision now requires changes to proceed.Aug 14 2019, 08:04

Fixed amount initialization and removed newlines.

This revision is now accepted and ready to land.Aug 16 2019, 07:57