Page MenuHomePhabricator
Differential D3812

Merge #12621: Avoid querying unnecessary model data when filtering transactions
ClosedPublic
Actions

Authored by nakihito on Aug 6 2019, 20:25.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING7ee85b34ec74: Merge #12621: Avoid querying unnecessary model data when filtering transactions
rABC7ee85b34ec74: Merge #12621: Avoid querying unnecessary model data when filtering transactions
Summary

1ee72a819f qt: Avoid querying unnecessary model data when filtering transactions (João Barbosa)

Pull request description:

This change moves down model data querying to where it's needed. The worst case remains the same (all data is queried and the row passes) but for the average case it improves the filter performance.

Tree-SHA512: 3bcaced029cb39dfbc5377246ce76634f9050ee3a3053db4d358fcbf4d8107c649e75841f21d69f1aebcaf1bbffe3eac784e6b03b366fdbbfec1e0da8f78d8ef

Backport of Core PR12621
https://github.com/bitcoin/bitcoin/pull/12621/

Depends on D3833

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12621
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7134
Build 12313: Bitcoin ABC Buildbot (legacy)
Build 12312: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 6 2019, 20:25
Owners added a reviewer: Restricted Owners Package.Aug 6 2019, 20:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2019, 20:25
teamcity added a comment.Aug 6 2019, 20:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 6 2019, 20:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7061: Diff 10644.Aug 6 2019, 20:31
Fabien requested changes to this revision.Aug 7 2019, 08:33
Fabien added inline comments.
src/qt/transactionfilterproxy.cpp
55 ↗(On Diff #10644)

There is a dependency missing here:
https://github.com/bitcoin/bitcoin/pull/11395/files

This revision now requires changes to proceed.Aug 7 2019, 08:33
nakihito planned changes to this revision.Aug 7 2019, 17:43

Missed a dependency. Will update once completed.

nakihito edited the summary of this revision. (Show Details)Aug 9 2019, 01:35
nakihito added a parent revision: D3833: Merge #11395: Qt: Enable searching by transaction id.
nakihito updated this revision to Diff 10746.Aug 12 2019, 23:02

Rebased off dependency.

nakihito planned changes to this revision.Aug 12 2019, 23:02
teamcity added a comment.Aug 12 2019, 23:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 12 2019, 23:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7127: Diff 10746.Aug 12 2019, 23:10
teamcity added a comment.Aug 12 2019, 23:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito updated this revision to Diff 10766.Aug 13 2019, 18:19

Rebased.

teamcity added a comment.Aug 13 2019, 18:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 13 2019, 18:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7134: Diff 10766.Aug 13 2019, 18:29
Fabien requested changes to this revision.Aug 14 2019, 08:04
Fabien added inline comments.
src/qt/transactionfilterproxy.cpp
31

Remove

65

Why ?

69

Dito

This revision now requires changes to proceed.Aug 14 2019, 08:04
nakihito updated this revision to Diff 10790.Aug 14 2019, 18:07

Fixed amount initialization and removed newlines.

teamcity added a comment.Aug 14 2019, 18:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 14 2019, 18:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7147: Diff 10790.Aug 14 2019, 18:14
Fabien accepted this revision.Aug 16 2019, 07:57
This revision is now accepted and ready to land.Aug 16 2019, 07:57
Closed by commit rABC7ee85b34ec74: Merge #12621: Avoid querying unnecessary model data when filtering transactions (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by nakihito). · Explain WhyAug 16 2019, 17:48
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC7ee85b34ec74: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING7ee85b34ec74: Merge #12621: Avoid querying unnecessary model data when filtering transactions.Sep 19 2019, 01:52

Revision Contents
Changeset List

PathSize
src/
qt/
30 lines

Diff 10766

View Options

src/qt/transactionfilterproxy.cpp

Loading...