Page MenuHomePhabricator

Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown.
ClosedPublic

Authored by markblundeberg on Aug 9 2019, 16:57.

Details

Summary

PR13162 backport https://github.com/bitcoin/bitcoin/pull/13162/files
fad63eb [logging] Don't incorrectly log that REJECT messages are unknown. (John Newbery)

Pull request description:

Reject messages are logged to debug.log if NET debug logging is enabled.

Because of the way the `ProcessMessages()` function is structured,
processing for REJECT messages will also drop through to the default
branch and incorrectly log `Unknown command "reject" from peer-?`. Fix
that by exiting from `ProcessMessages()` early.

without this PR:
```
2018-05-03T17:37:00.930600Z received: reject (21 bytes) peer=0
2018-05-03T17:37:00.930620Z Reject message code 16: spammy spam
2018-05-03T17:37:00.930656Z Unknown command "reject" from peer=0
```
with this PR:
```
2018-05-03T17:35:04.751246Z received: reject (21 bytes) peer=0
2018-05-03T17:35:04.751274Z Reject message code 16: spammy spam
```
Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13162
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7096
Build 12238: Bitcoin ABC Buildbot (legacy)
Build 12237: arc lint + arc unit

Event Timeline

just noticed this bug on testnet in my -debug=net logfile

This revision is now accepted and ready to land.Aug 9 2019, 17:12