Page MenuHomePhabricator

Merge #11200: Allow for aborting rescans in the GUI
ClosedPublic

Authored by nakihito on Aug 16 2019, 00:16.

Details

Summary

ae1d2b030 Give an error when rescan is aborted by the user (Andrew Chow)
69b01e6f8 Add cancel button to rescan progress dialog (Andrew Chow)

Pull request description:

A cancel button is added to the `showProgress` dialog that is used only for rescans. When clicked, `AbortRescan` is called directly to cancel the rescan.

Rescans triggered from the debug console will now be cancelable by clicking the cancel button.

Rescans triggered by a command (e.g. `importmulti`) will now give an error indicating that the rescan was aborted by the user (either by the `abortrescan` command or by clicking cancel).

Tree-SHA512: 4bb14998766de686e2318fbc9805758eccf5dbe628a7257d072c9ae2fb4f61303a0876f49988d6e5eddb261969b8a307c81c0c2df0a42ae909a43d738af3dc1b

Backport of Core PR11200
https://github.com/bitcoin/bitcoin/pull/11200/

Test Plan
make check
./bitcoin-qt -> help -> debug -> console -> rescanblockchain -> select cancel in the new window.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11200
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7173
Build 12391: Bitcoin ABC Buildbot (legacy)
Build 12390: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 16 2019, 00:16
Fabien requested changes to this revision.Aug 16 2019, 08:50
Fabien added inline comments.
src/wallet/rpcdump.cpp
661 ↗(On Diff #10824)

Nit: shoing => showing

664 ↗(On Diff #10824)

Move comment above

750 ↗(On Diff #10824)

Dito

This revision now requires changes to proceed.Aug 16 2019, 08:50
This revision is now accepted and ready to land.Aug 16 2019, 21:13