Page MenuHomePhabricator

Merge #12709: [wallet] shuffle sendmany recipients ordering
ClosedPublic

Authored by nakihito on Aug 16 2019, 23:43.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC56a2d7614990: Merge #12709: [wallet] shuffle sendmany recipients ordering
Summary

6acb02d635 add release note for sendmany output shuffling (Gregory Sanders)
cf6ef3c139 shuffle sendmany recipients ordering to shuffle tx outputs (Gregory Sanders)

Pull request description:

Unless there is something important I'm missing, we're just possible leaking information by preserving whatever ordering json object ordering is giving us (no guarantees at all).

This is unneeded for `sendtoaddress` since there is only 1 or 2 outputs, and the change output is shuffled in.

This will not effect `*raw` behavior by design, since users generally want full control using those apis. Further PRs could add optional args to over-ride that behavior.

Alternative ideas would be to sort the outputs by some deterministic ordering. (this would require more refactoring since change outputs are created and handled by caller)

related: https://github.com/bitcoin/bitcoin/pull/12699

Tree-SHA512: afdd990dde6a4a9e7eef7bb2e3342a46d11900d7fe6e6e4eb0cc6b5deed89df989fa7931a4bdcbf49b7c2d7a13c90169af3a166466e5760948bacabe3490f572

Backport of Core PR12709
https://github.com/bitcoin/bitcoin/pull/12709/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Aug 16 2019, 23:43
Owners added a reviewer: Restricted Owners Package.Aug 16 2019, 23:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 16 2019, 23:43
nakihito planned changes to this revision.Aug 16 2019, 23:43
nakihito requested review of this revision.Wed, Aug 28, 00:57
deadalnix accepted this revision.Wed, Aug 28, 14:10
This revision is now accepted and ready to land.Wed, Aug 28, 14:10