Page MenuHomePhabricator

[net] Tighten scope in net_processing
ClosedPublic

Authored by deadalnix on Wed, Aug 28, 17:37.

Details

Summary

This is a backport of Core PR13417:

  • Rescope g_enable_bip61 to net_processing
  • [move-only] Move things only referenced in net_processing out of header file
  • Restrict as much as possible in net_processing to translation unit

Mark everything else static or in an anonymous namespace.

  • Make g_enable_bip61 a member variable of PeerLogicValidation
Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Aug 28, 17:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Aug 28, 17:37
Fabien requested changes to this revision.Fri, Aug 30, 13:17
Fabien added a subscriber: Fabien.

Otherwise LGTM.

src/net_processing.cpp
1070 ↗(On Diff #11001)

There is a dependency missing here: https://github.com/bitcoin/bitcoin/pull/12603/files

This revision now requires changes to proceed.Fri, Aug 30, 13:17
deadalnix updated this revision to Diff 11243.Thu, Sep 12, 15:11

Rebase on top of D4052

Fabien accepted this revision.Thu, Sep 12, 18:27
This revision is now accepted and ready to land.Thu, Sep 12, 18:27
This revision was automatically updated to reflect the committed changes.