Page MenuHomePhabricator

[CI] Improve error catching and build log verbosity

Authored by Fabien on Sep 4 2019, 15:02.



Avoid missing errors from pipes and make the script print itself as it
runs. This will make the build logs more verbose and easier to debug
should an issue occur.

Test Plan

Run the CI build and gitian build, and check there is no error.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

jasonbcox requested changes to this revision.Sep 4 2019, 16:01
jasonbcox added a subscriber: jasonbcox.

set -eux is a good idea. I'm not yet convinced on set -o pipefail, though I think it's probably best to have it on by default rather than not.

Only requesting changes because the gitian build should added to the test plan.

This revision now requires changes to proceed.Sep 4 2019, 16:01
This revision is now accepted and ready to land.Sep 6 2019, 20:51

Disbable the prints during the IBD loop.