Page MenuHomePhabricator

[CI] Improve error catching and build log verbosity
ClosedPublic

Authored by Fabien on Sep 4 2019, 15:02.

Details

Summary

Avoid missing errors from pipes and make the script print itself as it
runs. This will make the build logs more verbose and easier to debug
should an issue occur.

Test Plan

Run the CI build and gitian build, and check there is no error.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Sep 4 2019, 15:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2019, 15:02
jasonbcox requested changes to this revision.Sep 4 2019, 16:01
jasonbcox added a subscriber: jasonbcox.

set -eux is a good idea. I'm not yet convinced on set -o pipefail, though I think it's probably best to have it on by default rather than not.

Only requesting changes because the gitian build should added to the test plan.

This revision now requires changes to proceed.Sep 4 2019, 16:01
Fabien edited the test plan for this revision. (Show Details)Sep 4 2019, 16:13
jasonbcox accepted this revision.Sep 6 2019, 20:51
This revision is now accepted and ready to land.Sep 6 2019, 20:51
Fabien updated this revision to Diff 11153.Sep 7 2019, 06:04

Disbable the prints during the IBD loop.

jasonbcox accepted this revision.Sep 9 2019, 17:01
This revision was automatically updated to reflect the committed changes.