Page MenuHomePhabricator

[CI] Workaround ubsan failure in functional tests
ClosedPublic

Authored by Fabien on Wed, Sep 4, 15:41.

Details

Summary

This will allow to run the undefined behavior sanitizer on the
functional tests.
For now the abc-p2p-compactblocks functional test is failing with ubsan (a message is missed, with no log) and the node fails to shut down, which causes the build to hang until timeout. This test is excluded from the list in order to allow for the other tests to run with ubsan, waiting for a fix.

Depends on D3993.

Test Plan

Run the CI build-ubsan build configuration.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Sep 4, 15:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Sep 4, 15:41
jasonbcox requested changes to this revision.Fri, Sep 6, 21:26
jasonbcox added a subscriber: jasonbcox.

A better description/rationale as we discussed earlier.

This revision now requires changes to proceed.Fri, Sep 6, 21:26
Fabien edited the summary of this revision. (Show Details)Sat, Sep 7, 05:51
Fabien updated this revision to Diff 11152.Sat, Sep 7, 05:54

Rebase, improve summary and add a comment asking for removal in the future.

It would probably be more useful to fix the undefined behavior.

Fabien added a comment.Sun, Sep 8, 09:27

I'd rather fix it, but so far I failed to do so.
This is most likely not an undefined behavior, because ubsan doesn't catch anything, I rather suspect some kind of timing issue exhibited by running ubsan.

jasonbcox accepted this revision.Mon, Sep 9, 16:35
This revision is now accepted and ready to land.Mon, Sep 9, 16:35
Fabien updated this revision to Diff 11354.Mon, Sep 16, 21:12

Rebase

This revision was automatically updated to reflect the committed changes.