Page MenuHomePhabricator

[CI] Make IBD a standard build configuration
ClosedPublic

Authored by Fabien on Fri, Sep 6, 12:40.

Details

Summary

This makes the CI IBD test a single entry point which can then be
reconfigured.

Test Plan
ABC_BUILD_NAME=build-ibd ./contrib/teamcity/build-configurations.sh
ABC_BUILD_NAME=build-ibd-no-assumevalid-checkpoint \
./contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Fri, Sep 6, 12:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Sep 6, 12:40
jasonbcox requested changes to this revision.Fri, Sep 6, 15:39
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/ibd.sh
18 ↗(On Diff #11121)

any reason to leave the /ibd out of the double quotes? DEBUG_LOG is this way, for example.

26 ↗(On Diff #11121)

This entire block can be one line:
: "${BITCOIND_BINARY:="${TOPLEVEL}/build/src/bitcoind"}"

This revision now requires changes to proceed.Fri, Sep 6, 15:39
Fabien updated this revision to Diff 11141.Fri, Sep 6, 17:20

Address comments.

jasonbcox requested changes to this revision.Fri, Sep 6, 17:22
jasonbcox added inline comments.
contrib/teamcity/ibd.sh
26 ↗(On Diff #11121)

Note the double quotes after the :=. This is important incase TOPLEVEL contains spaces.

This revision now requires changes to proceed.Fri, Sep 6, 17:22
Fabien requested review of this revision.Fri, Sep 6, 17:27
Fabien added inline comments.
contrib/teamcity/ibd.sh
26 ↗(On Diff #11121)

It's OK as the whole assignment is enclosed in double quotes.

jasonbcox accepted this revision.Fri, Sep 6, 20:48
This revision is now accepted and ready to land.Fri, Sep 6, 20:48

I created a new configuration for calling resource intensive configs via build-configurations. Running build-ibd-no-assumevalid-checkpoint now for sanity.

Fabien added a comment.Sat, Sep 7, 05:58

2 remarks:

  • The IBD failed due to timeout after 1h, which I think is a good value for all the other tests but not for IBD
  • The set -x should be removed during the loop, otherwise it prints a sleep every 100ms. I will update D3992.
jasonbcox requested changes to this revision.Wed, Sep 11, 17:09

The changes to ibd.sh got incorporated into D4003. Please rebase and use BITCOIND (or rename it to BITCOIND_BINARY, which is fine too).

This revision now requires changes to proceed.Wed, Sep 11, 17:09
Fabien updated this revision to Diff 11215.Wed, Sep 11, 19:14

Rebase on top of D4003.

jasonbcox accepted this revision.Thu, Sep 12, 15:19
This revision is now accepted and ready to land.Thu, Sep 12, 15:19
This revision was automatically updated to reflect the committed changes.