[CI] Make IBD a standard build configuration
ClosedPublic
Actions

Authored by Fabien on Sep 6 2019, 12:40.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGe180c51d5fb6: [CI] Make IBD a standard build configuration
rABCe180c51d5fb6: [CI] Make IBD a standard build configuration

Summary

This makes the CI IBD test a single entry point which can then be
reconfigured.

Test Plan

ABC_BUILD_NAME=build-ibd ./contrib/teamcity/build-configurations.sh
ABC_BUILD_NAME=build-ibd-no-assumevalid-checkpoint \
./contrib/teamcity/build-configurations.sh

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 6 2019, 12:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2019, 12:40

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7341: Diff 11121.Sep 6 2019, 12:49

Fabien added a child revision: D3993: [CI] Refactor the build configuration by moving out tests from the build.Sep 6 2019, 12:56

jasonbcox requested changes to this revision.Sep 6 2019, 15:39

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

contrib/teamcity/ibd.sh
18 ↗	(On Diff #11121)	any reason to leave the `/ibd` out of the double quotes? DEBUG_LOG is this way, for example.
26 ↗	(On Diff #11121)	This entire block can be one line: `: "${BITCOIND_BINARY:="${TOPLEVEL}/build/src/bitcoind"}"`

This revision now requires changes to proceed.Sep 6 2019, 15:39

Address comments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox requested changes to this revision.Sep 6 2019, 17:22

jasonbcox added inline comments.

contrib/teamcity/ibd.sh
26 ↗	(On Diff #11121)	Note the double quotes after the `:=`. This is important incase TOPLEVEL contains spaces.

This revision now requires changes to proceed.Sep 6 2019, 17:22

Fabien requested review of this revision.Sep 6 2019, 17:27

Fabien added inline comments.

contrib/teamcity/ibd.sh
26 ↗	(On Diff #11121)	It's OK as the whole assignment is enclosed in double quotes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7353: Diff 11141.Sep 6 2019, 17:32

jasonbcox accepted this revision.Sep 6 2019, 20:48

This revision is now accepted and ready to land.Sep 6 2019, 20:48

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

I created a new configuration for calling resource intensive configs via build-configurations. Running build-ibd-no-assumevalid-checkpoint now for sanity.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing failed.

2 remarks:

The IBD failed due to timeout after 1h, which I think is a good value for all the other tests but not for IBD
The set -x should be removed during the loop, otherwise it prints a sleep every 100ms. I will update D3992.