Page MenuHomePhabricator

zmq: log outbound message high water mark when reusing socket
AbandonedPublic

Authored by fpelliccioni on Sep 5 2019, 19:12.

Details

Reviewers
Fabien
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

Running master with src/bitcoind -zmqpubhashblockhwm=12345 -zmqpubrawtx=tcp://127.0.0.1:28332 -zmqpubhashtxhwm=5000 -zmqpubrawblock=tcp://127.0.0.1:28332 -zmqpubhashtx=tcp://127.0.0.1:28332 -zmqpubhashblock=tcp://127.0.0.1:28332 -debug=zmq:

2019-01-19T14:11:01Z zmq: version 4.3.1
2019-01-19T14:11:01Z zmq: Initialize notification interface
2019-01-19T14:11:01Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-19T14:11:01Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)

This PR:

2019-01-19T14:06:57Z zmq: version 4.3.1
2019-01-19T14:06:57Z zmq: Initialize notification interface
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-19T14:06:57Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
2019-01-19T14:06:57Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-19T14:06:57Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
2019-01-19T14:06:57Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)

Backport of Bitcoin Core PR15209
https://github.com/bitcoin/bitcoin/pull/15209

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-1522079d5
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7345
Build 12733: Bitcoin ABC Buildbot (legacy)
Build 12732: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 5 2019, 19:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2019, 19:12
jasonbcox requested changes to this revision.Sep 6 2019, 00:35
jasonbcox added a subscriber: jasonbcox.

Can you fix the summary? looks like some of it got cut off.

This revision now requires changes to proceed.Sep 6 2019, 00:35
fpelliccioni edited the summary of this revision. (Show Details)Sep 6 2019, 16:17
fpelliccioni edited the summary of this revision. (Show Details)

Can you fix the summary? looks like some of it got cut off.

Sure, fixed.
Thanks for catching it

fpelliccioni updated this revision to Diff 11133.Sep 6 2019, 16:21
fpelliccioni edited the summary of this revision. (Show Details)

Summary fixed.

This revision now requires changes to proceed.Sep 6 2019, 17:02
In D4009#94136, @Fabien wrote:

I will check it again. I tested it together with others (all together), I'm going to test it separately...

fpelliccioni planned changes to this revision.Sep 17 2019, 19:20

It depends on other backports not done yet.

fpelliccioni abandoned this revision.Tue, Nov 19, 17:05