Page MenuHomePhabricator
Differential D4009

zmq: log outbound message high water mark when reusing socket
AbandonedPublic
Actions

Authored by fpelliccioni on Sep 5 2019, 19:12.

Details

Reviewers
Fabien
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

Running master with src/bitcoind -zmqpubhashblockhwm=12345 -zmqpubrawtx=tcp://127.0.0.1:28332 -zmqpubhashtxhwm=5000 -zmqpubrawblock=tcp://127.0.0.1:28332 -zmqpubhashtx=tcp://127.0.0.1:28332 -zmqpubhashblock=tcp://127.0.0.1:28332 -debug=zmq:

2019-01-19T14:11:01Z zmq: version 4.3.1
2019-01-19T14:11:01Z zmq: Initialize notification interface
2019-01-19T14:11:01Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-19T14:11:01Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)

This PR:

2019-01-19T14:06:57Z zmq: version 4.3.1
2019-01-19T14:06:57Z zmq: Initialize notification interface
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-19T14:06:57Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
2019-01-19T14:06:57Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-19T14:06:57Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
2019-01-19T14:06:57Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)

Backport of Bitcoin Core PR15209
https://github.com/bitcoin/bitcoin/pull/15209

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-1522079d5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7334
Build 12711: Bitcoin ABC Buildbot (legacy)
Build 12710: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 5 2019, 19:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2019, 19:12
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 5 2019, 19:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 5 2019, 19:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 5 2019, 19:44

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7334: Diff 11108!Sep 5 2019, 19:44
teamcity added a comment.Sep 6 2019, 00:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox requested changes to this revision.Sep 6 2019, 00:35
jasonbcox added a subscriber: jasonbcox.

Can you fix the summary? looks like some of it got cut off.

This revision now requires changes to proceed.Sep 6 2019, 00:35
teamcity added a comment.Sep 6 2019, 00:44

Build Bitcoin-ABC / Diffs / Diff Testing failed.

fpelliccioni edited the summary of this revision. (Show Details)Sep 6 2019, 16:17
fpelliccioni edited the summary of this revision. (Show Details)
In D4009#93951, @jasonbcox wrote:

Can you fix the summary? looks like some of it got cut off.

Sure, fixed.
Thanks for catching it

fpelliccioni updated this revision to Diff 11133.Sep 6 2019, 16:21
fpelliccioni edited the summary of this revision. (Show Details)

Summary fixed.

teamcity added a comment.Sep 6 2019, 16:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 6 2019, 16:59

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7345: Diff 11133!Sep 6 2019, 16:59
Fabien requested changes to this revision.Sep 6 2019, 17:02

Something's wrong in this backport, it fails the build (see https://build.bitcoinabc.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=18761&_focus=1157)

This revision now requires changes to proceed.Sep 6 2019, 17:02
fpelliccioni added a comment.Sep 6 2019, 17:36
In D4009#94136, @Fabien wrote:

Something's wrong in this backport, it fails the build (see https://build.bitcoinabc.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=18761&_focus=1157)

I will check it again. I tested it together with others (all together), I'm going to test it separately...

fpelliccioni planned changes to this revision.Sep 17 2019, 19:20

It depends on other backports not done yet.

fpelliccioni abandoned this revision.Nov 19 2019, 17:05

Revision Contents
Changeset List

PathSize
src/
zmq/
3 lines

Diff 11108

View Options

src/zmq/zmqpublishnotifier.cpp

Loading...