Page MenuHomePhabricator

Do not construct out-of-bound pointers in SHA2 code
ClosedPublic

Authored by fpelliccioni on Fri, Sep 6, 16:37.

Details

Summary

This looks like an issue in the current SHA256/512 code, where a pointer outside of the area pointed to may be constructed (this is UB in theory, though in practice every supported platform treats pointers as integers).

Backport of Bitcoin Core PR15950
https://github.com/bitcoin/bitcoin/pull/15950

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fpelliccioni created this revision.Fri, Sep 6, 16:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Sep 6, 16:37
jasonbcox accepted this revision.Fri, Sep 6, 16:50
This revision is now accepted and ready to land.Fri, Sep 6, 16:50