Page MenuHomePhabricator
Differential D4018

Do not construct out-of-bound pointers in SHA2 code
ClosedPublic
Actions

Authored by fpelliccioni on Sep 6 2019, 16:37.

Details

Reviewers
Fabien
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code
rABC39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code
Summary

This looks like an issue in the current SHA256/512 code, where a pointer outside of the area pointed to may be constructed (this is UB in theory, though in practice every supported platform treats pointers as integers).

Backport of Bitcoin Core PR15950
https://github.com/bitcoin/bitcoin/pull/15950

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fpelliccioni created this revision.Sep 6 2019, 16:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2019, 16:37
Herald added a reviewer: deadalnix. · View Herald Transcript
jasonbcox accepted this revision.Sep 6 2019, 16:50
This revision is now accepted and ready to land.Sep 6 2019, 16:50
teamcity added a comment.Sep 6 2019, 16:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 6 2019, 16:54

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7348: Diff 11136!Sep 6 2019, 16:54
teamcity added a comment.Sep 11 2019, 20:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 11 2019, 20:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7348: Diff 11136.Sep 11 2019, 20:20
Closed by commit rABC39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by fpelliccioni). · Explain WhySep 11 2019, 20:32
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code.
fpelliccioni added a commit: rSTAGING39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code.Sep 19 2019, 02:16
nakihito mentioned this in D4042: Merge #11220: Check specific validation error in miner tests.Sep 19 2019, 19:58

Revision Contents
Changeset List

PathSize
src/
crypto/
2 lines
2 lines
2 lines

Diff 11222

View Options

src/crypto/ripemd160.cpp

Loading...
View Options

src/crypto/sha1.cpp

Loading...
View Options

src/crypto/sha512.cpp

Loading...