Page MenuHomePhabricator

Do not construct out-of-bound pointers in SHA2 code
ClosedPublic

Authored by fpelliccioni on Sep 6 2019, 16:37.

Details

Summary

This looks like an issue in the current SHA256/512 code, where a pointer outside of the area pointed to may be constructed (this is UB in theory, though in practice every supported platform treats pointers as integers).

Backport of Bitcoin Core PR15950
https://github.com/bitcoin/bitcoin/pull/15950

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 6 2019, 16:50