Differential D4118

Merge #13197: util: warn about ignored recursive -includeconf calls
ClosedPublic
Actions

Authored by nakihito on Sep 20 2019, 19:06.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING6dd7d191037f: Merge #13197: util: warn about ignored recursive -includeconf calls
rABC6dd7d191037f: Merge #13197: util: warn about ignored recursive -includeconf calls

Summary

2352aa9 test: Ensure that recursive -includeconf produces appropriate warnings (Karl-Johan Alm)
c5bcc7d util: warn about recursive -includeconf arguments in configuration files (Karl-Johan Alm)

Pull request description:

This is a follow-up PR to #10267, and addresses https://github.com/bitcoin/bitcoin/pull/10267#issuecomment-387546144.

~~I am adding extra work for @jnewbery in #12755 here -- maybe I should just rebase on top of that, but not sure what the appropriate approach is here.~~

Tree-SHA512: 87f0c32436b70424e33616ffb88d7cb699f90d6a583a10237e224b28fc936d6a9df95536c8c52ee8546b3942da92b2a357e61bf87e00d1462bc10d46d3bee352

Backport of Core PR13197
https://github.com/bitcoin/bitcoin/pull/13197/

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13197

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7528
Build 13096: Bitcoin ABC Buildbot (legacy)
Build 13095: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 20 2019, 19:06

Owners added a reviewer: Restricted Owners Package.Sep 20 2019, 19:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2019, 19:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7528: Diff 13040.Sep 20 2019, 19:16

deadalnix accepted this revision.Sep 21 2019, 12:06

This revision is now accepted and ready to land.Sep 21 2019, 12:06

Closed by commit rABC6dd7d191037f: Merge #13197: util: warn about ignored recursive -includeconf calls (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhySep 23 2019, 17:35

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC6dd7d191037f: Merge #13197: util: warn about ignored recursive -includeconf calls.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING6dd7d191037f: Merge #13197: util: warn about ignored recursive -includeconf calls.Sep 27 2019, 22:48

Revision Contents
Changeset List

Path

Size

src/

24 lines

test/

functional/

feature_includeconf.py

5 lines

Diff 13040

src/util.cpp

Loading...

test/functional/feature_includeconf.py

Loading...