Fix various RPC tests from the extended test suite
ClosedPublic
Actions

Authored by deadalnix on Aug 4 2017, 19:35.

Details

Reviewers

freetrader
CCulianu

Group Reviewers

Restricted Project

Commits

rSTAGINGe41fabb530d8: Fix various RPC tests from the extended test suite
rABCe41fabb530d8: Fix various RPC tests from the extended test suite

Summary

As usual, by providing a uahf start time in the future.

Test Plan

Run the tests.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 4 2017, 19:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 4 2017, 19:35

deadalnix mentioned this in D414: autopep8 various files.Aug 4 2017, 19:47

deadalnix mentioned this in D417: Remove some of the UAHF activation logic..Aug 4 2017, 22:08

Accepting with caveat that sickpig's comment about putting the var in 1 common place would have been a good idea, but isn't the end of the world either way.

Runs ok. Note some tests still fail but fewer fail with this series of diffs: D409, D411, D413, D414, so I will accept them since they are a step in the right direction...

Also D417 depends on these..

This revision is now accepted and ready to land.Aug 5 2017, 06:57

CCulianu mentioned this in D411: Also add the uahfstarttime to the rpc test framework.Aug 5 2017, 06:57

CCulianu mentioned this in D409: Fix a bunch of rpc tests by putting uahf start time in the future.

deadalnix mentioned this in rABC69a5b51c4223: autopep8 various files.Aug 5 2017, 09:52

Closed by commit rABCe41fabb530d8: Fix various RPC tests from the extended test suite (authored by deadalnix, committed by deadalnix). · Explain WhyAug 5 2017, 09:57

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in rABC658c6282afc1: Remove some of the UAHF activation logic..Aug 5 2017, 10:01