This is not a long term solution, but at least it put these tests back to green, which is what we want for now.
Details
Details
- Reviewers
freetrader CCulianu - Group Reviewers
Restricted Project - Commits
- rSTAGINGc570f3b9a15a: Fix a bunch of rpc tests by putting uahf start time in the future
rABCc570f3b9a15a: Fix a bunch of rpc tests by putting uahf start time in the future
Run the tests, check that they now pass.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Note: I am having trouble running rpc-test.py (see attached).
With this diff I actually pass more tests. Without it, I pass fewer.
But with it I still get errors on my Ubuntu 14.04 Linux system.
Note: Excuse my being a nub about rpc-test.py -- I normally don't run it as I test most of my stuff on my windows build env out of habit (for which the rpc-tests don't work).
Am I doing something wrong? Thoughts?
| qa/rpc-tests/abandonconflict.py | ||
|---|---|---|
| 12 ↗ | (On Diff #1018) | why not adding UAHF_START_TIME to test_framework.cdefs and use from test_framework.cdefs import LEGACY_MAX_BLOCK_SIZE this nit applies of course to all files in this Diff add UAHF_START_TIME |
| qa/rpc-tests/abandonconflict.py | ||
|---|---|---|
| 12 ↗ | (On Diff #1018) | No. This is clearly not the right activation time. |
| qa/rpc-tests/abandonconflict.py | ||
|---|---|---|
| 12 ↗ | (On Diff #1018) | cut and paste error, I meant: from test_framework.cdefs import UAHF_START_TIME |
Comment Actions
I'm ok with the changes you made, the only thing I would made differently (as I said already) is setting the new constant (UAHF_START_TIME = 2000000000)
in the test_framework/cdefs.py so that in case we need to change it we could change it only in one place. rather than in all the file u modified in this diff.