Page MenuHomePhabricator

Fix a bunch of rpc tests by putting uahf start time in the future
ClosedPublic

Authored by deadalnix on Aug 3 2017, 17:24.

Details

Summary

This is not a long term solution, but at least it put these tests back to green, which is what we want for now.

Test Plan

Run the tests, check that they now pass.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixrpctests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 641
Build 641: arc lint + arc unit

Event Timeline

Note: I am having trouble running rpc-test.py (see attached).

With this diff I actually pass more tests. Without it, I pass fewer.

But with it I still get errors on my Ubuntu 14.04 Linux system.

Note: Excuse my being a nub about rpc-test.py -- I normally don't run it as I test most of my stuff on my windows build env out of habit (for which the rpc-tests don't work).

Am I doing something wrong? Thoughts?

sickpig added inline comments.
qa/rpc-tests/abandonconflict.py
12

why not adding UAHF_START_TIME to test_framework.cdefs and use

from test_framework.cdefs import LEGACY_MAX_BLOCK_SIZE

this nit applies of course to all files in this Diff add UAHF_START_TIME

sickpig requested changes to this revision.Aug 4 2017, 09:46
This revision now requires changes to proceed.Aug 4 2017, 09:46
deadalnix edited edge metadata.
deadalnix added inline comments.
qa/rpc-tests/abandonconflict.py
12

No. This is clearly not the right activation time.

qa/rpc-tests/abandonconflict.py
12

cut and paste error, I meant:

from test_framework.cdefs import UAHF_START_TIME

I'm ok with the changes you made, the only thing I would made differently (as I said already) is setting the new constant (UAHF_START_TIME = 2000000000)
in the test_framework/cdefs.py so that in case we need to change it we could change it only in one place. rather than in all the file u modified in this diff.

I agree with sickpig's suggestion. @deadalnix.. thoughts?

Runs ok. Note some tests still fail but fewer fail with this series of diffs: D409, D411, D413, D414, so I will accept them since they are a step in the right direction...

Also D417 depends on these..

This revision is now accepted and ready to land.Aug 5 2017, 09:53
This revision was automatically updated to reflect the committed changes.