Page MenuHomePhabricator
Differential D411

Also add the uahfstarttime to the rpc test framework
ClosedPublic
Actions

Authored by deadalnix on Aug 3 2017, 20:32.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGINGf29a7b37a78c: Also add the uahfstarttime to the rpc test framework
rABCf29a7b37a78c: Also add the uahfstarttime to the rpc test framework
Summary

This will boot node with a proper uahfstarttime by default. This put a lot of test back to green now that we passed the fork date.

Test Plan
../qa/pull-tester/rpc-tests.py

See that there are more green tests than before.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 3 2017, 20:32
Harbormaster completed remote builds in B643: Diff 1024.Aug 3 2017, 20:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 3 2017, 20:32
CCulianu added subscribers: sickpig, CCulianu.Aug 4 2017, 21:23

in D409 @sickpig suggested you put this in 1 place then import the symbol.. any thoughts on that?

deadalnix mentioned this in D417: Remove some of the UAHF activation logic..Aug 4 2017, 22:08
CCulianu accepted this revision.Aug 5 2017, 06:56
CCulianu mentioned this in D414: autopep8 various files.
CCulianu mentioned this in D413: Fix various RPC tests from the extended test suite.

Runs ok. Note some tests still fail but fewer fail with this series of diffs: D409, D411, D413, D414, so I will accept them since they are a step in the right direction...

Also D417 depends on these..

This revision is now accepted and ready to land.Aug 5 2017, 06:57
CCulianu mentioned this in D409: Fix a bunch of rpc tests by putting uahf start time in the future.Aug 5 2017, 06:58
Closed by commit rABCf29a7b37a78c: Also add the uahfstarttime to the rpc test framework (authored by deadalnix, committed by deadalnix). · Explain WhyAug 5 2017, 09:55
This revision was automatically updated to reflect the committed changes.
deadalnix mentioned this in rABC658c6282afc1: Remove some of the UAHF activation logic..Aug 5 2017, 10:01

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
test_framework/
7 lines

Diff 1040

View Options

qa/rpc-tests/test_framework/test_framework.py

Loading...