Page MenuHomePhabricator
Differential D4139

Merge #13402: Document validationinterace callback blocking deadlock potential.
ClosedPublic
Actions

Authored by nakihito on Sep 23 2019, 17:54.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING4f5833a91e88: Merge #13402: Document validationinterace callback blocking deadlock potential.
rABC4f5833a91e88: Merge #13402: Document validationinterace callback blocking deadlock potential.
Summary

25bc9615b7 Document validationinterace callback blocking deadlock potential. (Matt Corallo)

Pull request description:

From the branches-I've-had-lying-around-and-forgot-to-PR department...

This is a comment-only PR, but the comments point out an API quirk that isn't exactly trivial. None of our use-cases right now hit this, but if we were to call SyncWithValidationInterfaceQueue (eg to limit queue depth) in ATMP, I'm pretty sure we'd hit a deadlock there.

Tree-SHA512: 889dd8fc9eb15d1f2aa5ca467e783bc8f07bc543b166b032741795b0db7a0df11a2846d3cb7c69bafa8d1acf970021001b742f52be06725a932813230c5b4a7b

Backport of Core PR13402
https://github.com/bitcoin/bitcoin/pull/13402/

Depends on D4138

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Sep 23 2019, 17:54
Owners added a reviewer: Restricted Owners Package.Sep 23 2019, 17:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2019, 17:54
nakihito planned changes to this revision.Sep 23 2019, 17:54
teamcity added a comment.Sep 23 2019, 17:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Sep 23 2019, 18:00
teamcity added a comment.Sep 23 2019, 18:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7555: Diff 13090.Sep 23 2019, 18:09
jasonbcox accepted this revision.Sep 23 2019, 21:49
This revision is now accepted and ready to land.Sep 23 2019, 21:49
Closed by commit rABC4f5833a91e88: Merge #13402: Document validationinterace callback blocking deadlock potential. (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhySep 23 2019, 22:23
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC4f5833a91e88: Merge #13402: Document validationinterace callback blocking deadlock potential..
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING4f5833a91e88: Merge #13402: Document validationinterace callback blocking deadlock potential..Sep 27 2019, 22:48

Revision Contents
Changeset List

PathSize
src/
16 lines
3 lines

Diff 13099

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...