Page MenuHomePhabricator

Revert change to PreciousBlock() comment made in D1182
ClosedPublic

Authored by nakihito on Mon, Sep 23, 17:41.

Details

Summary

Reverts change to commet for PreciousBlock() in validation.h that was
made in D1182. This reduces our code ownership and merge conflicts when
backporting.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Mon, Sep 23, 17:41
Owners added a reviewer: Restricted Owners Package.Mon, Sep 23, 17:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Sep 23, 17:41
nakihito planned changes to this revision.Mon, Sep 23, 17:41
nakihito requested review of this revision.Mon, Sep 23, 17:44

In the spirit of keeping consistent with D4045.

jasonbcox accepted this revision.Mon, Sep 23, 21:47

I don't mind this since resolving merge conflicts against these comments is becoming tiresome. Only downside is that we're losing a more valuable explanation of what a "precious" block is, but inspection of the code solves this.

This revision is now accepted and ready to land.Mon, Sep 23, 21:47