Page MenuHomePhabricator

Revert change to PreciousBlock() comment made in D1182
ClosedPublic

Authored by nakihito on Sep 23 2019, 17:41.

Details

Summary

Reverts change to commet for PreciousBlock() in validation.h that was
made in D1182. This reduces our code ownership and merge conflicts when
backporting.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
revertpreciousblockcomment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7554
Build 13148: Bitcoin ABC Buildbot (legacy)
Build 13147: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sep 23 2019, 17:41

In the spirit of keeping consistent with D4045.

I don't mind this since resolving merge conflicts against these comments is becoming tiresome. Only downside is that we're losing a more valuable explanation of what a "precious" block is, but inspection of the code solves this.

This revision is now accepted and ready to land.Sep 23 2019, 21:47