Page MenuHomePhabricator

Remove redundant variables, statements and forward declarations
ClosedPublic

Authored by fpelliccioni on Mon, Sep 23, 21:47.

Details

Summary

Remove redundant …

  • ~access modifiers,~
  • forward declarations,
  • unused variables,
  • statements, and
  • ~return types from lambdas.~

Backport of Bitcoin Core PR13691
https://github.com/bitcoin/bitcoin/pull/13691

Test Plan
make check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fpelliccioni created this revision.Mon, Sep 23, 21:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Sep 23, 21:47
jasonbcox requested changes to this revision.Mon, Sep 23, 21:52
jasonbcox added a subscriber: jasonbcox.

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

This revision now requires changes to proceed.Mon, Sep 23, 21:52

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

Sorry, what do you mean by "instances"?
The other changes of the PR have already been applied but have not been correctly tagged in your repo.

jasonbcox accepted this revision.Tue, Sep 24, 17:58
This revision is now accepted and ready to land.Tue, Sep 24, 17:58