Page MenuHomePhabricator

Remove redundant variables, statements and forward declarations
ClosedPublic

Authored by fpelliccioni on Sep 23 2019, 21:47.

Details

Summary

Remove redundant …

  • ~access modifiers,~
  • forward declarations,
  • unused variables,
  • statements, and
  • ~return types from lambdas.~

Backport of Bitcoin Core PR13691
https://github.com/bitcoin/bitcoin/pull/13691

Test Plan
make check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-62baa2878
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7560
Build 13160: Bitcoin ABC Buildbot (legacy)
Build 13159: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Sep 23 2019, 21:52
jasonbcox added a subscriber: jasonbcox.

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

This revision now requires changes to proceed.Sep 23 2019, 21:52

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

Sorry, what do you mean by "instances"?
The other changes of the PR have already been applied but have not been correctly tagged in your repo.

This revision is now accepted and ready to land.Sep 24 2019, 17:58