Page MenuHomePhabricator

Fix bip68-112-113-p2p.py
ClosedPublic

Authored by deadalnix on Aug 5 2017, 10:50.

Details

Summary

One more RPC test greened

Test Plan

Runt he test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixmoretests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 654
Build 654: arc lint + arc unit

Event Timeline

I'm ok with the changes you made, the only thing I would made differently (as I said already) is setting the new constant (UAHF_START_TIME = 2000000000)
in the test_framework/cdefs.py so that in case we need to change it we could change it only in one place. rather than in all the file u modified in this diff.

The test is passing with this changes

Didn't apply cleanly, but tested ok.

This revision is now accepted and ready to land.Aug 5 2017, 16:27
This revision was automatically updated to reflect the committed changes.