Page MenuHomePhabricator
Differential D420

Fix bip68-112-113-p2p.py
ClosedPublic
Actions

Authored by deadalnix on Aug 5 2017, 10:50.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGING75c7c9b644d8: Fix bip68-112-113-p2p.py
rABC75c7c9b644d8: Fix bip68-112-113-p2p.py
Summary

One more RPC test greened

Test Plan

Runt he test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixmoretests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 654
Build 654: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 5 2017, 10:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2017, 10:51
sickpig added a subscriber: sickpig.Aug 5 2017, 13:55

I'm ok with the changes you made, the only thing I would made differently (as I said already) is setting the new constant (UAHF_START_TIME = 2000000000)
in the test_framework/cdefs.py so that in case we need to change it we could change it only in one place. rather than in all the file u modified in this diff.

hanchon added a subscriber: hanchon.Aug 5 2017, 14:02

The test is passing with this changes

freetrader accepted this revision.Aug 5 2017, 16:27

Didn't apply cleanly, but tested ok.

This revision is now accepted and ready to land.Aug 5 2017, 16:27
Closed by commit rABC75c7c9b644d8: Fix bip68-112-113-p2p.py (authored by deadalnix, committed by deadalnix). · Explain WhyAug 5 2017, 16:56
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
9 lines

Diff 1045

View Options

qa/rpc-tests/bip68-112-113-p2p.py

Loading...