Page MenuHomePhabricator

[build-configurations] Make BUILD_DIR configurable
ClosedPublic

Authored by jasonbcox on Fri, Oct 4, 20:53.

Details

Summary

Allows building from any directory. This makes cleaning up the build dir predictable when executing from other scripts, thereby making them more robust.

Test Plan
ABC_BUILD_NAME=build-without-wallet ./build-configurations.sh  # default
ABC_BUILD_NAME=build-without-wallet BUILD_DIR=../../build-test ./build-configurations.sh

# Make sure build works as expected when the build dir doesn't exist
rm -rf ../../build
ABC_BUILD_NAME=build-without-wallet ./build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Fri, Oct 4, 20:53
jasonbcox updated this revision to Diff 13358.Fri, Oct 4, 21:09

Fixed a bug where non-existant build dir would fail

jasonbcox edited the test plan for this revision. (Show Details)Fri, Oct 4, 21:10
jasonbcox updated this revision to Diff 13359.Fri, Oct 4, 21:12

Simplify build dir creation

deadalnix accepted this revision.Sun, Oct 6, 17:42
This revision is now accepted and ready to land.Sun, Oct 6, 17:42
jasonbcox updated this revision to Diff 13378.Mon, Oct 7, 16:28

Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR

jasonbcox planned changes to this revision.Mon, Oct 7, 16:28
jasonbcox updated this revision to Diff 13379.Mon, Oct 7, 17:04

Fix failing check-java tests

This revision is now accepted and ready to land.Mon, Oct 7, 17:04
This revision was automatically updated to reflect the committed changes.