Page MenuHomePhabricator

[build-configurations] Make BUILD_DIR configurable
ClosedPublic

Authored by jasonbcox on Oct 4 2019, 20:53.

Details

Summary

Allows building from any directory. This makes cleaning up the build dir predictable when executing from other scripts, thereby making them more robust.

Test Plan
ABC_BUILD_NAME=build-without-wallet ./build-configurations.sh  # default
ABC_BUILD_NAME=build-without-wallet BUILD_DIR=../../build-test ./build-configurations.sh

# Make sure build works as expected when the build dir doesn't exist
rm -rf ../../build
ABC_BUILD_NAME=build-without-wallet ./build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
config-build-dir
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7694
Build 13427: Bitcoin ABC Buildbot (legacy)
Build 13426: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 4 2019, 20:53
jasonbcox updated this revision to Diff 13358.Oct 4 2019, 21:09

Fixed a bug where non-existant build dir would fail

jasonbcox edited the test plan for this revision. (Show Details)Oct 4 2019, 21:10
jasonbcox updated this revision to Diff 13359.Oct 4 2019, 21:12

Simplify build dir creation

deadalnix accepted this revision.Oct 6 2019, 17:42
This revision is now accepted and ready to land.Oct 6 2019, 17:42
jasonbcox updated this revision to Diff 13378.Oct 7 2019, 16:28

Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR

jasonbcox planned changes to this revision.Oct 7 2019, 16:28
jasonbcox updated this revision to Diff 13379.Oct 7 2019, 17:04

Fix failing check-java tests

This revision is now accepted and ready to land.Oct 7 2019, 17:04
This revision was automatically updated to reflect the committed changes.