Page MenuHomePhabricator
Differential D4213

[build-configurations] Make BUILD_DIR configurable
ClosedPublic
Actions

Authored by jasonbcox on Oct 4 2019, 20:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable
rABCcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable
Summary

Allows building from any directory. This makes cleaning up the build dir predictable when executing from other scripts, thereby making them more robust.

Test Plan
ABC_BUILD_NAME=build-without-wallet ./build-configurations.sh  # default
ABC_BUILD_NAME=build-without-wallet BUILD_DIR=../../build-test ./build-configurations.sh

# Make sure build works as expected when the build dir doesn't exist
rm -rf ../../build
ABC_BUILD_NAME=build-without-wallet ./build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
config-build-dir
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7690
Build 13419: Bitcoin ABC Buildbot (legacy)
Build 13418: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 4 2019, 20:53
Herald added a reviewer: deadalnix. · View Herald TranscriptOct 4 2019, 20:53
teamcity added a comment.Oct 4 2019, 20:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 4 2019, 20:54

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7690: Diff 13355!Oct 4 2019, 20:54
jasonbcox mentioned this in D4195: Added a land bot script.Oct 4 2019, 21:04
jasonbcox added a child revision: D4195: Added a land bot script.Oct 4 2019, 21:04
jasonbcox updated this revision to Diff 13358.Oct 4 2019, 21:09

Fixed a bug where non-existant build dir would fail

teamcity added a comment.Oct 4 2019, 21:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox edited the test plan for this revision. (Show Details)Oct 4 2019, 21:10
jasonbcox updated this revision to Diff 13359.Oct 4 2019, 21:12

Simplify build dir creation

teamcity added a comment.Oct 4 2019, 21:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 4 2019, 21:22

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7694: Diff 13359!Oct 4 2019, 21:22
Harbormaster failed remote builds in B7693: Diff 13358!Oct 4 2019, 21:26
teamcity added a comment.Oct 4 2019, 21:26

Build Bitcoin-ABC / Diffs / Diff Testing failed.

deadalnix accepted this revision.Oct 6 2019, 17:42
This revision is now accepted and ready to land.Oct 6 2019, 17:42
jasonbcox updated this revision to Diff 13378.Oct 7 2019, 16:28

Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR

jasonbcox planned changes to this revision.Oct 7 2019, 16:28
teamcity added a comment.Oct 7 2019, 16:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 7 2019, 16:42

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7703: Diff 13378!Oct 7 2019, 16:42
jasonbcox updated this revision to Diff 13379.Oct 7 2019, 17:04

Fix failing check-java tests

This revision is now accepted and ready to land.Oct 7 2019, 17:04
teamcity added a comment.Oct 7 2019, 17:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox mentioned this in D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.Oct 7 2019, 17:12
teamcity added a comment.Oct 7 2019, 17:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7704: Diff 13379.Oct 7 2019, 17:13
Closed by commit rABCcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable (authored by jasonbcox). · Explain WhyOct 8 2019, 21:45
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable.
jasonbcox added a commit: rSTAGINGcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable.Oct 9 2019, 20:12

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
4 lines

Diff 13355

View Options

contrib/teamcity/build-configurations.sh

Loading...