Page MenuHomePhabricator

[build-configurations] Make BUILD_DIR configurable
ClosedPublic

Authored by jasonbcox on Oct 4 2019, 20:53.

Details

Summary

Allows building from any directory. This makes cleaning up the build dir predictable when executing from other scripts, thereby making them more robust.

Test Plan
ABC_BUILD_NAME=build-without-wallet ./build-configurations.sh  # default
ABC_BUILD_NAME=build-without-wallet BUILD_DIR=../../build-test ./build-configurations.sh

# Make sure build works as expected when the build dir doesn't exist
rm -rf ../../build
ABC_BUILD_NAME=build-without-wallet ./build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fixed a bug where non-existant build dir would fail

Simplify build dir creation

This revision is now accepted and ready to land.Oct 6 2019, 17:42

Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR

Fix failing check-java tests

This revision is now accepted and ready to land.Oct 7 2019, 17:04