Page MenuHomePhabricator
Differential D4226

[wallet] `createwallet` RPC - create new wallet at runtime
AbandonedPublic
Actions

Authored by fpelliccioni on Oct 8 2019, 16:05.

Details

Reviewers
Fabien
deadalnix
jasonbcox
nakihito
Group Reviewers
Restricted Project
Summary

Adds a createwallet RPC to dynamically create a new wallet at runtime.

Backport of Bitcoin Core PR13058
https://github.com/bitcoin/bitcoin/pull/13058

Related to Github issue 335:
https://github.com/Bitcoin-ABC/bitcoin-abc/issues/335

Test Plan
make check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-343d4e44e
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7718
Build 13475: Bitcoin ABC Buildbot (legacy)
Build 13474: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Oct 8 2019, 16:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2019, 16:05
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Oct 8 2019, 16:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni edited the summary of this revision. (Show Details)Oct 8 2019, 16:06
fpelliccioni added a reviewer: jasonbcox.
deadalnix requested changes to this revision.Oct 8 2019, 16:14
deadalnix added inline comments.
doc/release-notes/release-notes-0.19.11.md
15

Why are you changing release notes from 0.19.11 ?

src/wallet/rpcwallet.cpp
3412
grep -r ~/bitcoin-abc/src/ -e createwallet

Gives me nothing, so it doesn't look like this patch is applicable to anything.

This revision now requires changes to proceed.Oct 8 2019, 16:14
teamcity added a comment.Oct 8 2019, 16:15

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7718: Diff 13404.Oct 8 2019, 16:15
nakihito requested changes to this revision.Oct 8 2019, 16:27
nakihito added a subscriber: nakihito.

This is a duplicate of D4220. In addition, it looks like either you either forgot to squash your changes or you are working on a branch with a dependency.

fpelliccioni added a comment.Oct 8 2019, 16:41
In D4226#101538, @nakihito wrote:

This is a duplicate of D4220. In addition, it looks like either you either forgot to squash your changes or you are working on a branch with a dependency.

Race condition, I started working on this and D4220 didn't exists.
I don't know what happend with the squash, but I did it.

fpelliccioni abandoned this revision.Oct 8 2019, 17:47

Duplicated D4220

Revision Contents
Changeset List

PathSize
doc/
release-notes/
11 lines
src/
wallet/
43 lines

Diff 13404

View Options

doc/release-notes/release-notes-0.19.11.md

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...