Page MenuHomePhabricator

Fix --wipeignore and add message indicating if wipe options are set and successful
ClosedPublic

Authored by nakihito on Oct 14 2019, 19:20.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCe29b97d0d32d: Fix --wipeignore and add message indicating if wipe options are set and…
Summary

The --wipeignore option was impossible to use because the constructor
would write the input for that parameter to fWipeBan instead.

Adds fprintf() statements for the --wipeignore and --wipeban
options. This makes testings changes to these options easier and gives
the user some confimation that the options were used.

Test Plan
make
./bitcoin-seeder --wipeban --wipeignore

Output should be as below:

Supporting whitelisted filters: 0x1,0x5,0x11,0x15
No nameserver set. Not starting DNS server.
Loading dnsseed.dat...Ban list wiped...Ignore list wiped...done
Starting seeder...done

Diff Detail

Repository
rABC Bitcoin ABC
Branch
UpdateSeederWipeOptions
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7762
Build 13563: Bitcoin ABC Buildbot (legacy)
Build 13562: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 14 2019, 19:20
Owners added a reviewer: Restricted Owners Package.Oct 14 2019, 19:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2019, 19:20
jasonbcox accepted this revision.Oct 14 2019, 20:00

Good catch.

This revision is now accepted and ready to land.Oct 14 2019, 20:00