Page MenuHomePhabricator
Differential D4252

rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest
ClosedPublic
Actions

Authored by nakihito on Oct 15 2019, 02:22.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING7e34a0fa1bdf: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest
rABC7e34a0fa1bdf: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest
Summary

Splits GetWalletForJSONRPCRequest() into two functions.

Refactor necessary for next part of this backport.

Partial backport of Core PR13111
https://github.com/bitcoin/bitcoin/pull/13111/commits/537efe19e696a97ca6a4f461b2c1b4cb7ab001b7

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 15 2019, 02:22
Owners added a reviewer: Restricted Owners Package.Oct 15 2019, 02:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2019, 02:22
nakihito planned changes to this revision.Oct 15 2019, 02:22
teamcity added a comment.Oct 15 2019, 02:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4253: rpc: Add unloadwallet RPC, release notes, and tests.Oct 15 2019, 02:24
Harbormaster completed remote builds in B7769: Diff 13552.Oct 15 2019, 02:32
teamcity added a comment.Oct 15 2019, 02:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Oct 15 2019, 02:41
Fabien requested changes to this revision.Oct 15 2019, 09:33

The test plan doesn't cover the change.

This revision now requires changes to proceed.Oct 15 2019, 09:33
nakihito edited the test plan for this revision. (Show Details)Oct 15 2019, 17:19
nakihito requested review of this revision.Oct 15 2019, 17:26

Updated test plan.

jasonbcox accepted this revision.Oct 16 2019, 20:00
deadalnix accepted this revision.Oct 17 2019, 01:46
Fabien accepted this revision.Oct 18 2019, 06:59
This revision is now accepted and ready to land.Oct 18 2019, 06:59
Closed by commit rABC7e34a0fa1bdf: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by nakihito). · Explain WhyOct 19 2019, 02:14
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC7e34a0fa1bdf: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
nakihito added a commit: rSTAGING7e34a0fa1bdf: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.Apr 7 2020, 21:27

Revision Contents
Changeset List

PathSize
src/
wallet/
17 lines

Diff 13613

View Options

src/wallet/rpcwallet.cpp

Loading...