Page MenuHomePhabricator

rpc: Add unloadwallet RPC, release notes, and tests
ClosedPublic

Authored by nakihito on Oct 15 2019, 02:24.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 15 2019, 02:24
nakihito added inline comments.
doc/release-notes.md
11 ↗(On Diff #13554)
src/wallet/rpcwallet.cpp
103 ↗(On Diff #13554)
3360 ↗(On Diff #13554)
3427 ↗(On Diff #13554)
3535 ↗(On Diff #13554)
4628 ↗(On Diff #13554)
src/wallet/wallet.cpp
98 ↗(On Diff #13554)
1380 ↗(On Diff #13554)
4380 ↗(On Diff #13554)
src/wallet/wallet.h
1229 ↗(On Diff #13554)
test/functional/wallet_multiwallet.py
277 ↗(On Diff #13554)
279 ↗(On Diff #13554)
284 ↗(On Diff #13554)

I don't see a good reason to block this based on the discussion in PR14941. That change is an improvement, but we'll need to backport up to it to get it.

This revision is now accepted and ready to land.Oct 16 2019, 20:15