Page MenuHomePhabricator

Merge #13248: [gui] Make proxy icon from statusbar clickable
ClosedPublic

Authored by nakihito on Oct 19 2019, 04:47.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC2d293e74c99d: Merge #13248: [gui] Make proxy icon from statusbar clickable
Summary

6d5fcad576962e5950641f7e7b113a6ac6f397e5 [gui] Make proxy icon from statusbar clickable (Cristian Mircea Messel)

Pull request description:

Clicking on the proxy icon will open settings showing the network tab

https://github.com/bitcoin/bitcoin/pull/11491#issuecomment-336685303

Tree-SHA512: c3549749296918818694a371326d1a3b1075478918aaee940b5c7119a7e2cb991dcfda78f20d44d6d001157b9b82951f0d5157b17f4f0d1a0a242795efade036

Backport of Core PR13248
https://github.com/bitcoin/bitcoin/pull/13248/

Depends on D4269

Test Plan
make check
./bitcoin-qt -proxy=<valid proxy>

Clicking the P icon in the bottom right corner should open up the network tab in the options menu.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Oct 19 2019, 04:47
Owners added a reviewer: Restricted Owners Package.Oct 19 2019, 04:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2019, 04:47
nakihito planned changes to this revision.Oct 19 2019, 04:47
nakihito requested review of this revision.Oct 19 2019, 04:48
Fabien requested changes to this revision.Oct 21 2019, 06:32
Fabien added inline comments.
src/qt/bitcoingui.cpp
858 ↗(On Diff #13620)

Braces

src/qt/optionsdialog.cpp
178 ↗(On Diff #13620)

Braces, also the next line.

This revision now requires changes to proceed.Oct 21 2019, 06:32
nakihito updated this revision to Diff 13626.Oct 21 2019, 17:36

Added braces.

deadalnix accepted this revision.Oct 23 2019, 01:29
Fabien accepted this revision.Oct 23 2019, 10:49
This revision is now accepted and ready to land.Oct 23 2019, 10:49