Page MenuHomePhabricator

Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore
ClosedPublic

Authored by nakihito on Oct 20 2019, 22:32.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC4db70e1fcd75: Merge #13114: wallet/keystore: Add Clang thread safety annotations for…
Summary

968b76f77c Add missing cs_KeyStore lock (practicalswift)
4bcd5bb87d Add locking annotations for variables guarded by cs_KeyStore (practicalswift)

Pull request description:

  • Add Clang thread safety annotations for variables guarded by cs_KeyStore
  • Add missing cs_KeyStore lock

Tree-SHA512: 7d93513c2da0cd564b9f1e75aa5156a454a4133eb845020fde8872e685dd5758353e93c33364aeea4a812c08353a810494e503a5ce160cc5be0af5af4bb2e6d7

Backport of Core PR13114
https://github.com/bitcoin/bitcoin/pull/13114/

Test Plan
../configure --enable-debug CXX=clang++ CC=clang
make clean
make check
test_runner.py

Run team city build-werror.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Oct 20 2019, 22:32
Owners added a reviewer: Restricted Owners Package.Oct 20 2019, 22:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2019, 22:32
nakihito planned changes to this revision.Oct 20 2019, 22:32
nakihito requested review of this revision.Oct 21 2019, 17:37
deadalnix requested changes to this revision.Wed, Oct 23, 01:13

The test plan is inadequate. If you actually checked for thread safety annotation warning from the compiler, you'd know that there are some since Oct, 3rd (!)

This revision now requires changes to proceed.Wed, Oct 23, 01:13
nakihito updated this revision to Diff 13689.Thu, Oct 24, 18:05

Rebased.

nakihito planned changes to this revision.Thu, Oct 24, 18:05
nakihito requested review of this revision.Thu, Oct 24, 18:45
nakihito edited the test plan for this revision. (Show Details)
deadalnix accepted this revision.Fri, Oct 25, 01:04
This revision is now accepted and ready to land.Fri, Oct 25, 01:04