Page MenuHomePhabricator

Separate CSeederNode class declaration from definition
ClosedPublic

Authored by nakihito on Fri, Oct 25, 22:35.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC46ff7d5583c1: Separate CSeederNode class declaration from definition
Summary

Separating the declaration from the definition of this class to allow
unit testing in the future without having to include bitcoin.cpp.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Fri, Oct 25, 22:35
Owners added a reviewer: Restricted Owners Package.Fri, Oct 25, 22:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Oct 25, 22:35
nakihito planned changes to this revision.Fri, Oct 25, 22:35
nakihito updated this revision to Diff 13717.Fri, Oct 25, 22:37

Removed extra new line.

nakihito planned changes to this revision.Fri, Oct 25, 22:37
nakihito requested review of this revision.Sun, Oct 27, 00:10
deadalnix accepted this revision.Mon, Oct 28, 00:03
This revision is now accepted and ready to land.Mon, Oct 28, 00:03